HomePhabricator

Give Owners packages the "O" monogram

Authored by epriestley on May 13 2016, 2:39 PM.

Description

Give Owners packages the "O" monogram

Summary:
Ref T10939. This isn't ideal because it's easy to confuse with zero ("O" vs "0") but I think this will mostly be read-only so it's probably one of the least-bad uses we could make of "O". We haven't really gotten into trouble with "I" (vs "1") for initiatives. Still, open to better ideas.

The goal here is to allow commit messages to include packages in some reasonable way, like Reviewers: O123 Package Name, epriestley, alincoln. The parser will ignore the "Package Name" part, that's just for humans. And I don't expect humans to type this, but when the use arc diff --edit or similar to update an existing revision, the reviewer needs to be represented somehow. It also needs to appear in the commit messages that arc land finalizes somehow.

I didn't hook up /O123 as a URI, but this should do everything else I think.

Test Plan:

  • Viewed package list.
  • Viewed package detail.
  • Did global search for O12.
  • Used O12 and {O12} remarkup rules.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15910

Details

Committed
epriestleyMay 14 2016, 12:18 AM
Pushed
epriestleyMay 14 2016, 12:18 AM
Reviewer
chad
Differential Revision
D15910: Give Owners packages the "O" monogram
Parents
rP44057ad26985: Consider packages when calculating Differential authority
Branches
Unknown
Tags
Unknown
Tasks
T10939: Support for OWNERS files
Build Status
Buildable 12200
Build 15405: Run Core Tests