HomePhabricator

Make PhabricatorActionListView logged-out user savvy

Description

Make PhabricatorActionListView logged-out user savvy

Summary:
Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI.

Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption.

Test Plan: played around with a mock all logged out (Ref T2652) and it worked!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2691

Differential Revision: https://secure.phabricator.com/D6416

Details

Provenance
btrahanAuthored on Jul 12 2013, 6:39 PM
Reviewer
epriestley
Differential Revision
Restricted Differential Revision
Parents
rPb6df427c2f6d: Add a "disabled" style
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task
Restricted Maniphest Task

Event Timeline

btrahan added a task: Restricted Maniphest Task.Sep 15 2017, 5:28 PM