HomePhabricator

PHUIPropertyListView

Description

PHUIPropertyListView

Summary: This builds out and implements PHUIPropertyListView (container) and PHUIPropertyListItemView (section) as well as adding tabs.

Test Plan: Tested each page I edited with the exception of Releeph and Phortune, though those changes look ok to me diff wise. Updated examples page with tabs.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7283

Details

Auditors
vrana
chad
Provenance
chadAuthored on Oct 11 2013, 2:53 PM
Reviewer
epriestley
Differential Revision
D7283: PHUIPropertyListView
Parents
rPf8d963a77e5f: Rename "Upload Image" dialog to "Upload File" to match purpose
Branches
Unknown
Tags
Unknown

Event Timeline

vrana raised a concern with this commit.Nov 9 2013, 5:06 PM
vrana added inline comments.
/src/applications/diffusion/controller/DiffusionLintController.php
326

This should be setActionList().

how do I clear this concern?

Yeah, sorry for the delay.