Stop doing an excessive amount of work in `diffusion.rawdiffquery`
Audit Required9329e6a12d9f

Authored by epriestley on Sep 20 2016, 12:57 PM.

Description

Stop doing an excessive amount of work in diffusion.rawdiffquery

Ref T11665.

Without -n 1, this logs the ENTIRE history of the repository. We
actually get the right result, but this is egregiously slow. Add -n 1
to return only one result.

It appears that I wrote this wrong way back in 2011, in D953. This
query is rarely used (until recently) which is likely why it has
escaped notice for so long.

Test Plan: Used Conduit console to execute diffusion.rawdiffquery.
Got the same results but spent 8ms instead of 200ms executing this
command, in a very small repository.

Details

Group Auditors
Cowboy Commits
H64 Triggered Audit
Committed
epriestleySep 20 2016, 1:00 PM
Pushed
epriestleySep 20 2016, 1:00 PM
Parents
rP03d323e9fdc2: Fix config-migration text for dashboard options
Branches
Unknown
Tags
Unknown
Tasks
T11665: repo002.phacility.net is heavily loaded