HomePhabricator

(stable) When proxying cluster HTTP requests, forward only selected headers

Description

(stable) When proxying cluster HTTP requests, forward only selected headers

In the live cluster, some subset of the forwarded headers are creating
some issues for HTTP repository operations.

Details

Group Auditors
Cowboy Commits
Provenance
epriestleyAuthored on Apr 9 2016, 10:39 AM
epriestleyPushed on Apr 9 2016, 10:40 AM
Parents
rPbf10fbdf6f5e: (stable) Promote 2016 Week 15
Branches
Unknown
Tags
Unknown
Build Status
Buildable 11612
Build 14519: Run Core Tests

Event Timeline

The behavior prior to this change (forwarding things by default) was fine locally, but headers and configuration in the production cluster differ and something was getting tripped up by it (I didn't dig into it enough to narrow it down).

Conceptually, I think forward selected headers is probably the right behavior, I just didn't want to disturb the spookiness of the old code more than I needed to. This moves us to selective forwarding (for now, of only "X-Hgarg" headers). This will probably need some additional tuning in the future.