HomePhabricator

Add DifferentialDiffQuery and change most callsites

Description

Add DifferentialDiffQuery and change most callsites

Summary:
Ref T603. This introduces a policy-aware DifferentialDiffQuery and converts most callsites.

I've left unusual callsites (mostly: hard to get the viewer, unusual query, queries related to active diffs) alone for now, so this isn't exhaustive but hits 60-80% of sites.

Test Plan: Created diff; created revision; viewed diffs and revisions; made additional conduit calls.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D6338

Details

Provenance
epriestleyAuthored on Jul 1 2013, 7:38 PM
Reviewer
btrahan
Differential Revision
Restricted Differential Revision
Parents
rP328aa383e460: Always provide a viewer when executing DifferentialRevisionQuery
Branches
Unknown
Tags
Unknown
Tasks
T603: Support permissions/policies in all Phabricator applications

Event Timeline