HomePhabricator

Provide UI hints about task subtypes

Tags
None
Referenced Files
F3539128: Screen Shot 2017-03-02 at 5.01.13 AM.png
May 26 2017, 8:58 PM
F3539167: Screen Shot 2017-03-02 at 4.48.09 AM.png
May 26 2017, 8:58 PM
F3539185: Screen Shot 2017-03-02 at 4.47.57 AM.png
May 26 2017, 8:58 PM
F3539144: Screen Shot 2017-03-02 at 5.01.20 AM.png
May 26 2017, 8:58 PM
Subscribers
None

Description

Provide UI hints about task subtypes

Summary:
Ref T12314. Open to counterdiffs / iterating / suggestions / skipping most or all of this, mostly just throwing this out there as a maybe-reasonable first pass.

When a task has a subtype (like "Plant" or "Animal"), provide some hints on the task list, workboards, and task detail.

To make these hints more useful, allow subtypes to have icons and colors.

Also use these icons and colors in the typeahead tokens.

The current rule is that we show the subtype if it's not the default subtype. Another rule we could use is "show the subtype if there's more than one subtype defined", but my guess is that most installs will mostly have something like "normal task" as the default subtype.

Test Plan:
The interfaces this affects are: task detail view, task list view, workboard cards, subtype typeahead.

Screen Shot 2017-03-02 at 5.01.13 AM.png (430×388 px, 22 KB)

Screen Shot 2017-03-02 at 5.01.20 AM.png (564×569 px, 47 KB)

Screen Shot 2017-03-02 at 4.48.09 AM.png (176×416 px, 19 KB)

Screen Shot 2017-03-02 at 4.47.57 AM.png (232×474 px, 22 KB)

Reviewers: chad

Reviewed By: chad

Subscribers: johnny-bit, bbrdaric, benwick, fooishbar

Maniphest Tasks: T12314

Differential Revision: https://secure.phabricator.com/D17451

Details

Provenance
epriestleyAuthored on Mar 2 2017, 1:02 PM
epriestleyPushed on May 26 2017, 8:58 PM
Reviewer
chad
Differential Revision
D17451: Provide UI hints about task subtypes
Parents
rP81809713e078: Try layering state icons on PHUICircleIconView
Branches
Unknown
Tags
Unknown
Tasks
T12314: Support formal task subtypes (like "bug" vs "feature")
Build Status
Buildable 17289
Build 23161: Run Core Tests