HomePhabricator

Fix an issue where PullLocal daemon could spin in an error loop

Description

Fix an issue where PullLocal daemon could spin in an error loop

Summary: Fixes T7106. If you have bad credentials AND you've pushed an "update this repository" message into the queue, the loop above this level ends up resetting the timer every time we go through it, so the daemon spins in a loop failing forever.

Test Plan:

  • Created a repo with bad credentials.
  • Clicekd "updated now" to queue an update message.
  • Saw daemon run in a loop.
  • Applied patch, no loop.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7106

Differential Revision: https://secure.phabricator.com/D11795