HomePhabricator

Fix bad Phortune Subscriptions query

Authored by epriestley.

Description

Fix bad Phortune Subscriptions query

Summary:
Fixes T7285. If the user tries to view a subscription they don't have permission to view, we may filter all the subscriptions out, then still try to load related data. This can fatal because it's invalid.

Instead, bail if we filtered everything.

Test Plan: Subscritption detail page of another user's subscription is now 404 instead of fatal.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7285

Differential Revision: https://secure.phabricator.com/D11780

Details

Committed
epriestleyFeb 16 2015, 7:17 PM
Pushed
epriestleyFeb 16 2015, 7:17 PM
Reviewer
chad
Differential Revision
D11780: Fix bad Phortune Subscriptions query
Parents
rPf206da2dbf3d: Increase height of message box on invite workflow
Branches
Unknown
Tags
Unknown
Tasks
T7285: Phortune can fatal on Subscription View page with bad query