(stable) Fix an issue where Herald rules could fail to evaluate at post-commit…
46fcd135ae68
Actions

Description

(stable) Fix an issue where Herald rules could fail to evaluate at post-commit time

Summary: Ref T13480. Some Herald fields need audit information, which recent changes to Herald adapters discarded. For now, just load it unconditionally.

Test Plan: Triggered an Audit-related rule locally.

Maniphest Tasks: T13480

Differential Revision: https://secure.phabricator.com/D20962

Details

Provenance

epriestley	Authored on Feb 3 2020, 1:04 PM
epriestley	Pushed on Feb 3 2020, 1:10 PM

Differential Revision

D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time

Parents

rPcc11dff7d317: (stable) Promote 2020 Week 5

Branches

Unknown

Tags

Unknown

Tasks

T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields

Build Status

Buildable 23769
Build 32687: Run Core Tests

Event Timeline

epriestley committed rP46fcd135ae68: (stable) Fix an issue where Herald rules could fail to evaluate at post-commit… (authored by epriestley).Feb 3 2020, 1:10 PM

epriestley added a task: T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

epriestley added an edge: D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time.

Harbormaster completed building B23769: rP46fcd135ae68: (stable) Fix an issue where Herald rules could fail to evaluate at post-commit….Feb 3 2020, 1:12 PM

Changes (1)

Path

Size

src/

applications/

diffusion/

herald/

HeraldCommitAdapter.php

rP46fcd135ae68

View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php