Paths

Table of Contentst

Rename "PhabricatorHash::digest()" to "weakDigest()"
3d816e94dfbe
Actions

Description

Rename "PhabricatorHash::digest()" to "weakDigest()"

Summary: Ref T12509. This encourages code to move away from HMAC+SHA1 by making the method name more obviously undesirable.

Test Plan: grep, browsed around.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12509

Differential Revision: https://secure.phabricator.com/D17632

Details

Provenance

epriestley	Authored on Apr 6 2017, 5:08 PM
epriestley	Pushed on Apr 6 2017, 10:43 PM

Reviewer

chad

Differential Revision

D17632: Rename "PhabricatorHash::digest()" to "weakDigest()"

Parents

rP3a3626834e60: Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256

Branches

Unknown

Tags

Unknown

Tasks

T12509: Plan the path forward from HMAC-SHA1

Build Status

Buildable 16345
Build 21735: Run Core Tests

Event Timeline

epriestley committed rP3d816e94dfbe: Rename "PhabricatorHash::digest()" to "weakDigest()" (authored by epriestley).Apr 6 2017, 10:43 PM

epriestley added a task: T12509: Plan the path forward from HMAC-SHA1.

Harbormaster failed to build B16345: rP3d816e94dfbe: Rename "PhabricatorHash::digest()" to "weakDigest()"!Apr 6 2017, 10:44 PM

Harbormaster completed building B16345: rP3d816e94dfbe: Rename "PhabricatorHash::digest()" to "weakDigest()".Apr 6 2017, 10:48 PM

Changes (20)

Path

Size

resources/

sql/

patches/

20130530.sessionhash.php

src/

applications/

auth/

controller/

PhabricatorAuthController.php

PhabricatorAuthLoginController.php

PhabricatorAuthOneTimeLoginController.php

PhabricatorAuthTerminateSessionController.php

engine/

PhabricatorAuthSessionEngine.php

factor/

PhabricatorTOTPAuthFactor.php

provider/

PhabricatorAuthProvider.php

query/

PhabricatorAuthSessionQuery.php

base/

controller/

PhabricatorController.php

celerity/

resources/

CelerityResources.php

config/

check/

PhabricatorPathSetupCheck.php

diffusion/

controller/

DiffusionServeController.php

gitlfs/

DiffusionGitLFSTemporaryTokenType.php

files/

engine/

PhabricatorChunkedFileStorageEngine.php

metamta/

receiver/

PhabricatorObjectMailReceiver.php

people/

storage/

PhabricatorUser.php

settings/

panel/

PhabricatorPasswordSettingsPanel.php

PhabricatorSessionsSettingsPanel.php

infrastructure/

util/

PhabricatorHash.php

rP3d816e94dfbe

View Options

resources/sql/patches/20130530.sessionhash.php

View Options

src/applications/auth/controller/PhabricatorAuthController.php

View Options

src/applications/auth/controller/PhabricatorAuthLoginController.php

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

View Options

src/applications/auth/controller/PhabricatorAuthTerminateSessionController.php

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

View Options

src/applications/auth/query/PhabricatorAuthSessionQuery.php

View Options

src/applications/base/controller/PhabricatorController.php

View Options

src/applications/celerity/resources/CelerityResources.php

View Options

src/applications/config/check/PhabricatorPathSetupCheck.php

View Options

src/applications/diffusion/controller/DiffusionServeController.php

View Options

src/applications/diffusion/gitlfs/DiffusionGitLFSTemporaryTokenType.php

View Options

src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php

View Options

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

View Options

src/applications/people/storage/PhabricatorUser.php

View Options

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php

View Options

src/infrastructure/util/PhabricatorHash.php

Rename "PhabricatorHash::digest()" to "weakDigest()"3d816e94dfbeActions

Description

Details

Event Timeline

Changes (20)

rP3d816e94dfbe

resources/sql/patches/20130530.sessionhash.php

src/applications/auth/controller/PhabricatorAuthController.php

src/applications/auth/controller/PhabricatorAuthLoginController.php

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

src/applications/auth/controller/PhabricatorAuthTerminateSessionController.php

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

src/applications/auth/provider/PhabricatorAuthProvider.php

src/applications/auth/query/PhabricatorAuthSessionQuery.php

src/applications/base/controller/PhabricatorController.php

src/applications/celerity/resources/CelerityResources.php

src/applications/config/check/PhabricatorPathSetupCheck.php

src/applications/diffusion/controller/DiffusionServeController.php

src/applications/diffusion/gitlfs/DiffusionGitLFSTemporaryTokenType.php

src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

src/applications/people/storage/PhabricatorUser.php

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php

src/infrastructure/util/PhabricatorHash.php

Rename "PhabricatorHash::digest()" to "weakDigest()"
3d816e94dfbe
Actions