HomePhabricator

Record new commits in the push log

Description

Record new commits in the push log

Summary:
Ref T4195. Like the previous diffs, these both create a useful log and give us an object to hand off to Herald.

Surface this information in Diffusion, too, and clean things up a little bit.

Test Plan: {F87565}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4195

Differential Revision: https://secure.phabricator.com/D7718

Details

Auditors
jonoberheide
Provenance
epriestleyAuthored on Dec 5 2013, 7:59 PM
Reviewer
btrahan
Differential Revision
D7718: Record new commits in the push log
Parents
rP3f5046014948: Allow repository push logs to be filtered by pusher and repository
Branches
Unknown
Tags
Unknown
Tasks
T4195: Implement pre-commit Herald rules

Event Timeline

if it's a svn repository, $author_phid is undefined with this new code path.

/src/applications/diffusion/controller/DiffusionCommitController.php
527

$author_phid is assigned here if it's not a svn repo

548

$author_phid is used here, which will be undefined if the repo is svn.

Ack, thanks! Should be fixed in HEAD now, see rP7a5c3cc8. Let us know if you run into anything else.