HomePhabricator

Fix exception on diff parse on FreeBSD

Description

Fix exception on diff parse on FreeBSD

FreeBSD 9.2 comes with diff tool version 2.8.7 which behaves
a bit different from how it is expected to. Namely for diff
between two binary files it says:

Files A and B are differ

This was leading to an exception when browsing revisions with
changes in binary files.

Tweaked parse patterns in order to fix this issue. Now both
older and newer diff tools are supported.

See: https://github.com/facebook/arcanist/pull/139

Reviewed by: epriestley

Details

Group Auditors
Cowboy Commits
Provenance
sergey.vfxAuthored on
epriestleyCommitted on Jan 18 2014, 7:13 PM
epriestleyPushed on Jan 18 2014, 7:13 PM
Reviewer
epriestley
Parents
rARCa247e2109394: Call willLintPath() hook from PhutilLinter
Branches
Unknown
Tags
Unknown

Event Timeline