Page MenuHomePhabricator

copumpkin (Daniel Peebles)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 16 2014, 4:17 AM (509 w, 1 d)
Availability
Available

Recent Activity

Mar 20 2015

copumpkin added a comment to T5210: Support GitHub Enterprise as an OAuth Provider.

Aha, I see. The only real difference between GitHub Enterprise and GitHub.com is a couple of URLs (github.com -> yourdomain, and api.github.com -> yourdomain/api/v3/), which is what I was hoping to be able to configure with my proposal :(

Mar 20 2015, 7:49 PM · Auth
copumpkin awarded T5210: Support GitHub Enterprise as an OAuth Provider a Like token.
Mar 20 2015, 7:17 PM · Auth
copumpkin added a comment to T5210: Support GitHub Enterprise as an OAuth Provider.

Judging by the code, it looks like the OAuth logic is fairly cleanly separated from the various specific OAuth implementations (which inherit from it). Instead of (or as well as) giving us a collection of hardcoded GitHub/Amazon/Asana/Disqus OAuth providers in the auth options, could there just be a catch-all configurable OAuth provider option?

Mar 20 2015, 7:17 PM · Auth