User Details
User Details
- User Since
- Jul 16 2014, 4:17 AM (548 w, 3 d)
- Availability
- Available
Mar 20 2015
Mar 20 2015
copumpkin added a comment to T5210: Support GitHub Enterprise as an OAuth Provider.
Aha, I see. The only real difference between GitHub Enterprise and GitHub.com is a couple of URLs (github.com -> yourdomain, and api.github.com -> yourdomain/api/v3/), which is what I was hoping to be able to configure with my proposal :(
copumpkin awarded T5210: Support GitHub Enterprise as an OAuth Provider a Like token.
copumpkin added a comment to T5210: Support GitHub Enterprise as an OAuth Provider.
Judging by the code, it looks like the OAuth logic is fairly cleanly separated from the various specific OAuth implementations (which inherit from it). Instead of (or as well as) giving us a collection of hardcoded GitHub/Amazon/Asana/Disqus OAuth providers in the auth options, could there just be a catch-all configurable OAuth provider option?