Page MenuHomePhabricator

MichaelDeGroot (Michaël de Groot)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 16 2013, 11:03 AM (545 w, 1 d)
Availability
Available

Recent Activity

Oct 18 2013

MichaelDeGroot added a comment to T3973: Use case: Weekly reviews.

The show all files inline is indeed what I was looking for! :)

Oct 18 2013, 9:28 AM · Differential

Oct 17 2013

MichaelDeGroot added a comment to T3973: Use case: Weekly reviews.

Thanks for adding the review, I think this would work perfectly for us, assuming it's fairly easy to add some javascript that asynchronously opens all the commits.

Oct 17 2013, 2:36 PM · Differential
MichaelDeGroot edited projects for T3973: Use case: Weekly reviews, added: Differential; removed Phabricator.
Oct 17 2013, 2:33 PM · Differential
MichaelDeGroot added a comment to T3973: Use case: Weekly reviews.

Oh by the way, the 'normal' commits in the trunk are mainly bugfixes and small features, so therefor I think it can be done in so little time.

Oct 17 2013, 2:32 PM · Differential
MichaelDeGroot added a comment to T3973: Use case: Weekly reviews.

The plan is to setup 2 different types of reviews. The weekly review is for any commit into the trunk. Bigger features get developed in branches, when a developer is ready to commit this branch into the trunk a pre-commit review is being done (or possibly even during developing on this branch) by a senior developer.
At another company I've seen this working 6 developers in 1-3 hours where we didn't work with branches.The issue there was that some junior developers were only able to find basic mistakes (coding standards, typo, etc...) so we decided to team the junior with a senior to get the most out of it.
Here the idea is that a senior reviews the branch, so big architectural changes are always reviewed by a senior.

Oct 17 2013, 2:27 PM · Differential
MichaelDeGroot added a comment to T3973: Use case: Weekly reviews.

Yes, that's correct. We're split up in several teams, +/- 10 developers per team so reviewing 1 week should cost about 2-4 hours per reviewers. This way you can plan someone to do the review instead of having a process consuming time at unknown moments.

Oct 17 2013, 1:46 PM · Differential
MichaelDeGroot added a comment to T3973: Use case: Weekly reviews.

By the way, an issue with your workaround on IRC is that each commit would be a separate review request so a lot of monkey click work.

Oct 17 2013, 8:33 AM · Differential

Oct 16 2013

MichaelDeGroot assigned T3973: Use case: Weekly reviews to epriestley.
Oct 16 2013, 4:36 PM · Differential