Page MenuHomePhabricator
Feed Advanced Search

Jan 31 2017

keithpitt added a comment to T12173: Support Buildkite as a Harbormaster target.

Oh! I think you found a bug. If you go to "GitHub Settings" on that page, enable "Trigger builds after pushing code", then enable "Build tags", then save. Then switch back to "Disable GitHub triggered builds", then save, it should hopefully start working for you.

Jan 31 2017, 11:32 PMHarbormaster, Phacility
keithpitt added a comment to T12173: Support Buildkite as a Harbormaster target.

Check out your pipeline settings, if you "ctrl-f" for the word "tag" - is there an option somewhere?

Jan 31 2017, 11:23 PMHarbormaster, Phacility
keithpitt added a comment to T12173: Support Buildkite as a Harbormaster target.

We don't have any examples of checkout hooks, but you can read the built in code path here that does the checkout: https://github.com/buildkite/agent/blob/master/agent/bootstrap.go#L948-L1051

Jan 31 2017, 10:43 PMHarbormaster, Phacility
keithpitt added a comment to T12173: Support Buildkite as a Harbormaster target.

I'll check in with Sam at Buildkite who wrote most of the tag/git handling gear in the Buildkite Agent. In the meantime, you can override our "checkout" process with a hook: https://buildkite.com/docs/agent/hooks to get it working how'd you prefer it to work. Once you've done that, we can figure out what we need to change on our end to merge in what ever bits you want.

Jan 31 2017, 10:41 PMHarbormaster, Phacility
keithpitt added a comment to T12173: Support Buildkite as a Harbormaster target.

No problems, just lemme know what you need to make it easier and I'll see what I can do :) Also if you have any BK questions feel free to reach out! 馃悎

Jan 31 2017, 10:27 PMHarbormaster, Phacility
keithpitt added a comment to T12173: Support Buildkite as a Harbormaster target.

Ah! Using "phabricator/diff/1234" as the branch name would be pretty cool - we'd _might_ be able to do some special handling of that branch name pattern in our UI to make the whole experience a bit nicer. We could probably also extract the diff number out and have a nice link to the diff on the Phabricator end.

Jan 31 2017, 9:54 PMHarbormaster, Phacility
keithpitt added a comment to T12173: Support Buildkite as a Harbormaster target.

Howdy! Keith from Buildkite here. We actually started a Phabricator integration a while ago, but got stuck on the Phabriactor side of things. A ton of our customers use it, so we're super pumped to see it getting some traction.

Jan 31 2017, 9:00 PMHarbormaster, Phacility