I think it would be useful to display an error if the generation process fails.
In most cases, we could remove the >dev/null 2>/dev/null to get status and error messages. They're currently fairly verbose. One advantage is that this will translate properly and can more easily give users detailed diagnostic information (like "no permission to write file"). A disadvantage is that errors like "arc not in path" won't have much context.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 11 2020
Apr 11 2020
Apr 8 2020
Apr 8 2020
Dec 22 2014
Dec 22 2014
Been poking around at the code. The following function looks promising: https://secure.phabricator.com/diffusion/P/browse/master/src/applications/differential/parser/DifferentialHunkParser.php;a366f85c118bf6b857155792446c397dac03e0a3$229
Dec 19 2014
Dec 19 2014
Haha, noobs calling everything "Phabricator".
Also, Python's built-in difflib also does the right thing (at least for this small example).
cakoose renamed T6791: Side-by-side diff for source code is noisier than other tools from Side-by-side diff is noisier than other tools to Side-by-side diff for source code is noisier than other tools.
How do you decide how to apply light-green vs dark-green highlighting? Is that something diff gives you?
Dec 3 2013
Dec 3 2013
cakoose added a comment to T4165: ExecFuture->resolveKill() should check if $this->proc is null before calling proc_terminate..
This came up with a custom Arcanist linter we have (I didn't write it, but I'm now trying to fix the exception). The lintPath() function looks like this:
Nov 27 2013
Nov 27 2013
cakoose raised the priority of T4165: ExecFuture->resolveKill() should check if $this->proc is null before calling proc_terminate. from to Needs Triage.
Nov 21 2013
Nov 21 2013
cakoose raised the priority of T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist from to Needs Triage.