Page MenuHomePhabricator
Feed Advanced Search

Sep 29 2015

RyanNerd added a comment to T2393: Adds a "Needs Verification" state to Audits.

Anything done on this? I'd like to request a pull to work on this.
I am referring to @matthijsmvs feature request:

Sep 29 2015, 7:07 PM · Restricted Project, Audit
RyanNerd added a comment to T9444: The function phutil_console_get_terminal_width needs to work with Windows.

I forgot about that. The Windows

mode

command will return the words such as "Columns" per the locale of Windows. So looking for literally "Columns" will only work for the English Windows locales.

Sep 29 2015, 6:40 PM · Windows, libphutil

Sep 28 2015

RyanNerd added a comment to T9444: The function phutil_console_get_terminal_width needs to work with Windows.

"I see" said the blind man as he tripped over his code.

Sep 28 2015, 6:17 PM · Windows, libphutil
RyanNerd added a comment to T9444: The function phutil_console_get_terminal_width needs to work with Windows.

+1 vote from me to comment the use of regular expressions (how can anything that looks like this "'/CON.*:(\n[^|]+?){3}(?<cols>\d+)/" be called regular?)

Sep 28 2015, 3:05 AM · Windows, libphutil

Sep 21 2015

RyanNerd added a comment to T9444: The function phutil_console_get_terminal_width needs to work with Windows.

Here is the code snippet for Unix/Linux:

Sep 21 2015, 2:40 AM · Windows, libphutil
RyanNerd added a comment to T9444: The function phutil_console_get_terminal_width needs to work with Windows.

In the code the unix Command tput cols is used. All this really does is look at the $TERM environment variable and infers the column count from that. On my Mint 17.2 this is 'xterm' and the tput cols command always returns 80 (which is the default column width for xterm).

Sep 21 2015, 2:31 AM · Windows, libphutil

Sep 19 2015

RyanNerd added a project to T9444: The function phutil_console_get_terminal_width needs to work with Windows: Windows.
Sep 19 2015, 2:10 AM · Windows, libphutil
RyanNerd added a comment to T1273: There should be a way to specify phutil library dependencies.

Thanks for the response. I have similar concerns about security and using Composer in my own personal projects.
Perhaps similar logic to bower could be leveraged (which I think is more security conscious).
I'd hate to have to reinvent the wheel for library dependencies.

Sep 19 2015, 2:05 AM · libphutil

Sep 18 2015

RyanNerd added a comment to T1273: There should be a way to specify phutil library dependencies.

Forgive my ignorance, but isn't this what Composer does?

Sep 18 2015, 9:11 PM · libphutil
RyanNerd created T9444: The function phutil_console_get_terminal_width needs to work with Windows.
Sep 18 2015, 9:02 PM · Windows, libphutil