Page MenuHomePhabricator
Feed Advanced Search

Jun 17 2015

aj added a comment to T8571: Make accepting audits faster/fewer clicks.

Also, feel free to re-close if they are actually the same issue (sorry :/)

Jun 17 2015, 8:01 AM · Restricted Project
aj reopened T8571: Make accepting audits faster/fewer clicks as "Open".

Sorry but I'm not entirely sure that these are actually the same issue:
In t5815, btrahan specifically said that he was not going to implement a "quick accept" button. Instead was planning to implement a "go to next" mode.

Jun 17 2015, 8:00 AM · Restricted Project
aj added a comment to T8573: All reviewers should be allowed to mark a comment as done.

First, thanks so much for adding 'done' comments, it's definitely helps. I can speak to why we asked for this a little bit.

Jun 17 2015, 7:05 AM · Restricted Project, Differential, Restricted Project
aj added a comment to T8570: Improve browsability of directories which change name frequently.

So, here's one example:
We have this file "etherpad/src/notes/control/maincontrol.ts". Right now the "history" page shows:
https://www.dropbox.com/s/bmaip9ubr45yggd/Screenshot%202015-06-16%2023.51.56.png?dl=0

Jun 17 2015, 6:57 AM · Diffusion (v3), Restricted Project, Restricted Project

Jun 16 2015

aj added a comment to T8571: Make accepting audits faster/fewer clicks.

Thanks for the response. There is absolutely review going on. Until my team launches our product we will depend pretty heavily on post-commit reviews, so it's not uncommon for me to have 50-150 audits in one week to review. A lot of those will be really small commits, only a couple of lines, so I can accept them pretty quickly. Probably 90% of the audits will be accepted without any comments right now, so I guess this is a request to maybe try to optimize for that?

Jun 16 2015, 9:32 PM · Restricted Project