Fix file PHID extraction in Pholio
ClosedPublic
Actions

Authored by epriestley on Feb 17 2023, 6:30 PM.

Tags

None

Referenced Files

	F13080190: D21858.id.diff
	Wed, Apr 24, 5:18 AM

	F13080170: D21858.id52098.diff
	Wed, Apr 24, 4:53 AM

	Unknown Object (File)
	Tue, Apr 23, 6:52 PM

	Unknown Object (File)
	Tue, Apr 23, 6:52 PM

	Unknown Object (File)
	Sat, Apr 20, 2:20 PM

	Unknown Object (File)
	Fri, Apr 19, 10:47 PM

	Unknown Object (File)
	Fri, Apr 19, 6:19 AM

	Unknown Object (File)
	Fri, Apr 19, 5:54 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rPa83cb99e856a: Fix file PHID extraction in Pholio

Summary

Ref T13682. After some change prior change likely connected to T13682, file PHIDs fail to extract properly in Pholio.

Test Plan

Created a new Pholio mock with at least one image.
Before: fatal when extracting data from this datastructure.
After: clean mock creation.

Diff Detail

Repository

rP Phabricator

Branch

pholio1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25768
Build 35596: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Feb 17 2023, 6:30 PM

epriestley created this revision.

Harbormaster completed remote builds in B25768: Diff 52097.Feb 17 2023, 6:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2023, 6:36 PM

Closed by commit rPa83cb99e856a: Fix file PHID extraction in Pholio (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa83cb99e856a: Fix file PHID extraction in Pholio.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

xaction/

PholioImageFileTransaction.php

13 lines

Diff 52097

View Options

src/applications/pholio/xaction/PholioImageFileTransaction.php

Fix file PHID extraction in PholioClosedPublicActions