Page MenuHomePhabricator
Differential D21858

Fix file PHID extraction in Pholio
ClosedPublic
Actions

Authored by epriestley on Feb 17 2023, 6:30 PM.
Tags
None
Referenced Files
F19811390: D21858.id.diff
Wed, Mar 4, 12:47 AM
F19787438: D21858.id52098.diff
Wed, Feb 25, 1:40 PM
F19767744: D21858.id.diff
Thu, Feb 19, 5:27 PM
F19745575: D21858.diff
Sun, Feb 15, 3:48 PM
F19714764: D21858.id52098.diff
Thu, Feb 12, 2:47 AM
F19705309: D21858.id52098.diff
Wed, Feb 11, 6:42 AM
F19565855: D21858.id52097.diff
Jan 31 2026, 7:13 PM
F19533927: D21858.id52097.diff
Jan 20 2026, 9:17 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rPa83cb99e856a: Fix file PHID extraction in Pholio
Summary

Ref T13682. After some change prior change likely connected to T13682, file PHIDs fail to extract properly in Pholio.

Test Plan
  • Created a new Pholio mock with at least one image.
  • Before: fatal when extracting data from this datastructure.
  • After: clean mock creation.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25768
Build 35596: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Feb 17 2023, 6:30 PM
epriestley created this revision.
Harbormaster completed remote builds in B25768: Diff 52097.Feb 17 2023, 6:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2023, 6:36 PM
Closed by commit rPa83cb99e856a: Fix file PHID extraction in Pholio (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPa83cb99e856a: Fix file PHID extraction in Pholio.

Revision Contents
Changeset List

PathSize
src/
applications/
pholio/
xaction/
13 lines

Diff 52097

View Options

src/applications/pholio/xaction/PholioImageFileTransaction.php

Loading...
Phabricator · Built by Phacility