Page MenuHomePhabricator
Differential D21858

Fix file PHID extraction in Pholio
ClosedPublic
Actions

Authored by epriestley on Feb 17 2023, 6:30 PM.
Tags
None
Referenced Files
F15402408: D21858.id.diff
Mon, Mar 17, 10:22 PM
F15402404: D21858.id52098.diff
Mon, Mar 17, 10:20 PM
F15402107: D21858.id52097.diff
Mon, Mar 17, 8:40 PM
F15399866: D21858.id.diff
Mon, Mar 17, 8:13 AM
F15391143: D21858.id52098.diff
Sat, Mar 15, 8:23 AM
F15391142: D21858.id52097.diff
Sat, Mar 15, 8:23 AM
F15391140: D21858.id.diff
Sat, Mar 15, 8:23 AM
F15379277: D21858.id52097.diff
Thu, Mar 13, 7:59 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rPa83cb99e856a: Fix file PHID extraction in Pholio
Summary

Ref T13682. After some change prior change likely connected to T13682, file PHIDs fail to extract properly in Pholio.

Test Plan
  • Created a new Pholio mock with at least one image.
  • Before: fatal when extracting data from this datastructure.
  • After: clean mock creation.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25768
Build 35596: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Feb 17 2023, 6:30 PM
epriestley created this revision.
Harbormaster completed remote builds in B25768: Diff 52097.Feb 17 2023, 6:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2023, 6:36 PM
Closed by commit rPa83cb99e856a: Fix file PHID extraction in Pholio (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPa83cb99e856a: Fix file PHID extraction in Pholio.

Revision Contents
Changeset List

PathSize
src/
applications/
pholio/
xaction/
13 lines

Diff 52097

View Options

src/applications/pholio/xaction/PholioImageFileTransaction.php

Loading...
Phabricator · Built by Phacility