Page MenuHomePhabricator
Differential D21852

Fix repository URI generation for SVN commit identifiers represented with integer types
ClosedPublic
Actions

Authored by epriestley on Jun 3 2022, 10:00 PM.
Tags
None
Referenced Files
F13198345: D21852.diff
Mon, May 13, 5:51 AM
F13197393: D21852.diff
Mon, May 13, 12:09 AM
F13192455: D21852.diff
Sun, May 12, 7:42 AM
F13182972: D21852.diff
Fri, May 10, 5:37 AM
F13179891: D21852.diff
Wed, May 8, 9:31 PM
Unknown Object (File)
Tue, May 7, 2:59 PM
Unknown Object (File)
Sat, May 4, 7:12 PM
Unknown Object (File)
Sat, May 4, 11:40 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented…
rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with…
Summary

Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in phutil_nonempty_string(), which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan

Will deploy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
2 lines

Diff 52083

View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility