Page MenuHomePhabricator
Differential D21852

Fix repository URI generation for SVN commit identifiers represented with integer types
ClosedPublic
Actions

Authored by epriestley on Jun 3 2022, 10:00 PM.
Tags
None
Referenced Files
F14398332: D21852.id52083.diff
Sun, Dec 22, 1:41 PM
Unknown Object (File)
Thu, Dec 19, 2:08 AM
Unknown Object (File)
Fri, Dec 13, 7:28 PM
Unknown Object (File)
Tue, Dec 10, 5:27 PM
Unknown Object (File)
Mon, Dec 9, 1:55 AM
Unknown Object (File)
Sun, Dec 8, 6:33 PM
Unknown Object (File)
Thu, Dec 5, 7:08 AM
Unknown Object (File)
Wed, Dec 4, 11:52 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented…
rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with…
Summary

Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in phutil_nonempty_string(), which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan

Will deploy.

Diff Detail

Repository
rP Phabricator
Branch
scalar1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25760
Build 35588: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
2 lines

Diff 52082

View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility