Fix repository URI generation for SVN commit identifiers represented with integer types
ClosedPublic
Actions

Authored by epriestley on Jun 3 2022, 10:00 PM.

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented…
rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with…

Summary

Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in phutil_nonempty_string(), which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan

Will deploy.

Diff Detail

Repository

rP Phabricator

Branch

scalar1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25760
Build 35588: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Jun 3 2022, 10:00 PM

epriestley created this revision.

Harbormaster completed remote builds in B25760: Diff 52082.Jun 3 2022, 10:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2022, 10:01 PM

Closed by commit rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with….

epriestley added a commit: rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented….Jun 3 2022, 10:16 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

2 lines

Diff 52082

View Options

src/applications/repository/storage/PhabricatorRepository.php

Fix repository URI generation for SVN commit identifiers represented with integer typesClosedPublicActions