Page MenuHomePhabricator
Differential D21852

Fix repository URI generation for SVN commit identifiers represented with integer types
ClosedPublic
Actions

Authored by epriestley on Jun 3 2022, 10:00 PM.
Tags
None
Referenced Files
F15409334: D21852.diff
Wed, Mar 19, 4:15 AM
F15391279: D21852.id52083.diff
Sat, Mar 15, 9:11 AM
F15391278: D21852.id52082.diff
Sat, Mar 15, 9:11 AM
F15391277: D21852.id.diff
Sat, Mar 15, 9:11 AM
F15382739: D21852.id.diff
Fri, Mar 14, 2:13 PM
F15377294: D21852.diff
Thu, Mar 13, 8:33 AM
F15340829: D21852.diff
Sun, Mar 9, 5:14 PM
F15286200: D21852.id52083.diff
Tue, Mar 4, 7:03 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented…
rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with…
Summary

Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in phutil_nonempty_string(), which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan

Will deploy.

Diff Detail

Repository
rP Phabricator
Branch
scalar1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25760
Build 35588: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
2 lines

Diff 52082

View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility