Page MenuHomePhabricator
Differential D21843

Move Slowvote response visibility to a separate object
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 4:40 PM.
Tags
None
Referenced Files
F13270451: D21843.id52062.diff
Wed, May 29, 9:43 AM
F13270450: D21843.id52060.diff
Wed, May 29, 9:43 AM
F13270449: D21843.id.diff
Wed, May 29, 9:43 AM
F13268804: D21843.diff
Wed, May 29, 5:23 AM
F13255035: D21843.diff
Sat, May 25, 4:21 AM
F13233401: D21843.diff
Tue, May 21, 2:16 AM
F13221065: D21843.diff
Sun, May 19, 2:15 AM
F13209949: D21843.id52060.diff
Fri, May 17, 3:02 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP23094b495024: Move Slowvote response visibility to a separate object
Summary

Ref T13682. This change supports modifying these constants to be sensible strings instead of opaque integers.

Test Plan

Created and edited polls.

Diff Detail

Repository
rP Phabricator
Branch
svote3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25750
Build 35578: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 26 2022, 4:40 PM
epriestley created this revision.
Harbormaster completed remote builds in B25750: Diff 52060.May 26 2022, 4:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 4:58 PM
Closed by commit rP23094b495024: Move Slowvote response visibility to a separate object (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP23094b495024: Move Slowvote response visibility to a separate object.

Revision Contents
Changeset List

Diff 52060

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/constants/SlowvotePollResponseVisibility.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

Loading...
View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php

Loading...
Phabricator · Built by Phacility