Differential D21843

Move Slowvote response visibility to a separate object
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 4:40 PM.

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP23094b495024: Move Slowvote response visibility to a separate object

Summary

Ref T13682. This change supports modifying these constants to be sensible strings instead of opaque integers.

Test Plan

Created and edited polls.

Diff Detail

Repository

rP Phabricator

Branch

svote3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25750
Build 35578: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 26 2022, 4:40 PM

epriestley created this revision.

Harbormaster completed remote builds in B25750: Diff 52060.May 26 2022, 4:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 4:58 PM

Closed by commit rP23094b495024: Move Slowvote response visibility to a separate object (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP23094b495024: Move Slowvote response visibility to a separate object.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

slowvote/

constants/

SlowvotePollResponseVisibility.php

75 lines

controller/

PhabricatorSlowvoteEditController.php

12 lines

storage/

PhabricatorSlowvotePoll.php

11 lines

view/

SlowvoteEmbedView.php

24 lines

xaction/

PhabricatorSlowvoteResponsesTransaction.php

34 lines

Diff 52060

View Options

src/__phutil_library_map__.php

View Options

src/applications/slowvote/constants/SlowvotePollResponseVisibility.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

View Options

src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php

Move Slowvote response visibility to a separate objectClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 52060

src/__phutil_library_map__.php

src/applications/slowvote/constants/SlowvotePollResponseVisibility.php

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

src/applications/slowvote/view/SlowvoteEmbedView.php

src/applications/slowvote/xaction/PhabricatorSlowvoteResponsesTransaction.php

Move Slowvote response visibility to a separate object
ClosedPublic
Actions

Revision Contents
Changeset List