Page MenuHomePhabricator
Differential D21835

Give "FileAttachment" policy support and a query object
ClosedPublic
Actions

Authored by epriestley on May 23 2022, 5:24 PM.
Tags
None
Referenced Files
F21881980: D21835.diff
Thu, Aug 13, 6:07 PM
Unknown Object (File)
Sat, Aug 8, 1:05 PM
Unknown Object (File)
Fri, Aug 7, 4:02 PM
Unknown Object (File)
Thu, Aug 6, 1:22 AM
Unknown Object (File)
Thu, Jul 30, 10:52 AM
Unknown Object (File)
Jul 13 2026, 7:43 AM
Unknown Object (File)
Jul 13 2026, 7:42 AM
Unknown Object (File)
Jun 30 2026, 1:34 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP5033ef6f88b3: Give "FileAttachment" policy support and a query object
Summary

Ref T13682. This supports an "Attached Files" curtain UI element.

Test Plan

See next change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 23 2022, 5:24 PM
epriestley created this revision.
Harbormaster completed remote builds in B25737: Diff 52037.May 23 2022, 5:24 PM
epriestley updated this revision to Diff 52038.May 23 2022, 5:33 PM
  • Fix unit test.
Harbormaster completed remote builds in B25738: Diff 52038.May 23 2022, 5:33 PM
epriestley updated this revision to Diff 52039.May 23 2022, 5:49 PM
  • Also fix indirect reference attachment/scrambling test.
Harbormaster completed remote builds in B25739: Diff 52039.May 23 2022, 5:49 PM
epriestley updated this revision to Diff 52040.May 23 2022, 6:11 PM
  • Further improve unit test coverage and test "reference doesn't grant view permission".
Harbormaster completed remote builds in B25740: Diff 52040.May 23 2022, 6:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
Closed by commit rP5033ef6f88b3: Give "FileAttachment" policy support and a query object (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP5033ef6f88b3: Give "FileAttachment" policy support and a query object.

Revision Contents
Changeset List

Diff 52044

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/query/PhabricatorFileAttachmentQuery.php

Loading...
View Options

src/applications/files/query/PhabricatorFileQuery.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...
View Options

src/applications/files/storage/__tests__/PhabricatorFileTestCase.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility