Page MenuHomePhabricator

Give "FileAttachment" policy support and a query object
ClosedPublic

Authored by epriestley on May 23 2022, 5:24 PM.
Tags
None
Referenced Files
F11025127: D21835.diff
Fri, Aug 12, 10:27 AM
F11022590: D21835.id52044.diff
Thu, Aug 11, 1:33 PM
F11022589: D21835.id52040.diff
Thu, Aug 11, 1:33 PM
F11022588: D21835.id52039.diff
Thu, Aug 11, 1:33 PM
F11022585: D21835.id52038.diff
Thu, Aug 11, 1:33 PM
F11022583: D21835.id52037.diff
Thu, Aug 11, 1:33 PM
F11022582: D21835.id.diff
Thu, Aug 11, 1:33 PM
Unknown Object (File)
Wed, Aug 10, 9:55 AM
Subscribers
None

Details

Summary

Ref T13682. This supports an "Attached Files" curtain UI element.

Test Plan

See next change.

Diff Detail

Repository
rP Phabricator
Branch
file4
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25737
Build 35565: arc lint + arc unit

Unit TestsFailed

TimeTest
23 msPhabricatorFileTestCase::testFileIndirectScramble
EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/arcanist/src/utils/utils.php(911): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 911) #1 /Users/epriestley/dev/core/lib/phabricator/src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php(160): phutil_split_lines(NULL, true)
208 msPhabricatorCelerityTestCase::testCelerityMaps
3 assertions passed.
9 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
48 msPhabricatorFileTestCase::testFileDirectScramble
2 assertions passed.
8 msPhabricatorFileTestCase::testFileStorageDelete
1 assertion passed.
View Full Test Results (1 Failed · 16 Passed)

Event Timeline

epriestley created this revision.
  • Also fix indirect reference attachment/scrambling test.
  • Further improve unit test coverage and test "reference doesn't grant view permission".
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.