Differential D21835

Give "FileAttachment" policy support and a query object
ClosedPublic
Actions

Authored by epriestley on May 23 2022, 5:24 PM.

Tags

None

Referenced Files

	F14086761: D21835.id52037.diff
	Sat, Nov 23, 4:40 PM

	F14083881: D21835.id52038.diff
	Sat, Nov 23, 5:50 AM

	Unknown Object (File)
	Tue, Nov 19, 7:52 AM

	Unknown Object (File)
	Fri, Nov 15, 3:06 AM

	Unknown Object (File)
	Tue, Nov 12, 12:04 AM

	Unknown Object (File)
	Sun, Nov 10, 4:48 PM

	Unknown Object (File)
	Fri, Nov 8, 6:31 PM

	Unknown Object (File)
	Thu, Nov 7, 12:38 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP5033ef6f88b3: Give "FileAttachment" policy support and a query object

Summary

Ref T13682. This supports an "Attached Files" curtain UI element.

Test Plan

See next change.

Diff Detail

Repository

Branch

file4

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25737
Build 35565: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	23 ms	PhabricatorFileTestCase::testFileIndirectScramble EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/arcanist/src/utils/utils.php(911): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 911) #1 /Users/epriestley/dev/core/lib/phabricator/src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php(160): phutil_split_lines(NULL, true)
	208 ms	PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed.
	9 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	48 ms	PhabricatorFileTestCase::testFileDirectScramble 2 assertions passed.
	8 ms	PhabricatorFileTestCase::testFileStorageDelete 1 assertion passed.
		View Full Test Results (1 Failed · 16 Passed)

Event Timeline

epriestley requested review of this revision.May 23 2022, 5:24 PM

epriestley created this revision.

Harbormaster completed remote builds in B25737: Diff 52037.May 23 2022, 5:24 PM

Fix unit test.

Harbormaster completed remote builds in B25738: Diff 52038.May 23 2022, 5:33 PM

Also fix indirect reference attachment/scrambling test.

Harbormaster completed remote builds in B25739: Diff 52039.May 23 2022, 5:49 PM

Further improve unit test coverage and test "reference doesn't grant view permission".

Harbormaster completed remote builds in B25740: Diff 52040.May 23 2022, 6:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM

Closed by commit rP5033ef6f88b3: Give "FileAttachment" policy support and a query object (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5033ef6f88b3: Give "FileAttachment" policy support and a query object.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

files/

query/

PhabricatorFileAttachmentQuery.php

110 lines

storage/

PhabricatorFileAttachment.php

57 lines

Diff 52037

src/__phutil_library_map__.php

Loading...

src/applications/files/query/PhabricatorFileAttachmentQuery.php

Loading...

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...