Ref T13682. This supports an "Attached Files" curtain UI element.
Details
Details
See next change.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- file4
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 25739 Build 35567: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 45 ms | PhabricatorFileTestCase::testFileIndirectScramble Assertion failed, expected 'true' (at PhabricatorFileTestCase.php:140): Changing attached object view policy should scramble secret.
ACTUAL VALUE
| |
| 213 ms | PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed. | |
| 9 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 34 ms | PhabricatorFileTestCase::testFileDirectScramble 2 assertions passed. | |
| 10 ms | PhabricatorFileTestCase::testFileStorageDelete 1 assertion passed. | |
| View Full Test Results (1 Failed · 16 Passed) |
Event Timeline
Comment Actions
- Further improve unit test coverage and test "reference doesn't grant view permission".