Page MenuHomePhabricator
Differential D21835

Give "FileAttachment" policy support and a query object
ClosedPublic
Actions

Authored by epriestley on May 23 2022, 5:24 PM.
Tags
None
Referenced Files
F14086761: D21835.id52037.diff
Sat, Nov 23, 4:40 PM
F14083881: D21835.id52038.diff
Sat, Nov 23, 5:50 AM
Unknown Object (File)
Tue, Nov 19, 7:52 AM
Unknown Object (File)
Fri, Nov 15, 3:06 AM
Unknown Object (File)
Tue, Nov 12, 12:04 AM
Unknown Object (File)
Sun, Nov 10, 4:48 PM
Unknown Object (File)
Fri, Nov 8, 6:31 PM
Unknown Object (File)
Thu, Nov 7, 12:38 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP5033ef6f88b3: Give "FileAttachment" policy support and a query object
Summary

Ref T13682. This supports an "Attached Files" curtain UI element.

Test Plan

See next change.

Diff Detail

Repository
rP Phabricator
Branch
file4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25738
Build 35566: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 23 2022, 5:24 PM
epriestley created this revision.
Harbormaster completed remote builds in B25737: Diff 52037.May 23 2022, 5:24 PM
epriestley updated this revision to Diff 52038.May 23 2022, 5:33 PM
  • Fix unit test.
Harbormaster completed remote builds in B25738: Diff 52038.May 23 2022, 5:33 PM
epriestley updated this revision to Diff 52039.May 23 2022, 5:49 PM
  • Also fix indirect reference attachment/scrambling test.
Harbormaster completed remote builds in B25739: Diff 52039.May 23 2022, 5:49 PM
epriestley updated this revision to Diff 52040.May 23 2022, 6:11 PM
  • Further improve unit test coverage and test "reference doesn't grant view permission".
Harbormaster completed remote builds in B25740: Diff 52040.May 23 2022, 6:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
Closed by commit rP5033ef6f88b3: Give "FileAttachment" policy support and a query object (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP5033ef6f88b3: Give "FileAttachment" policy support and a query object.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
query/
110 lines
storage/
57 lines
transactions/
editor/
7 lines

Diff 52038

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/query/PhabricatorFileAttachmentQuery.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility