Provide missing default attachment list for Files transactions
ClosedPublic
Actions

Authored by epriestley on May 23 2022, 4:24 PM.

Tags

None

Referenced Files

	F15456133: D21834.diff
	Sun, Mar 30, 7:15 AM

	F15451874: D21834.id52036.diff
	Sat, Mar 29, 12:13 AM

	F15451862: D21834.id.diff
	Sat, Mar 29, 12:11 AM

	F15440812: D21834.id.diff
	Wed, Mar 26, 2:44 PM

	F15439350: D21834.id52035.diff
	Wed, Mar 26, 7:06 AM

	F15439194: D21834.diff
	Wed, Mar 26, 6:17 AM

	F15426447: D21834.id.diff
	Sun, Mar 23, 8:49 AM

	F15424298: D21834.diff
	Sat, Mar 22, 9:19 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP8cd02e6727e3: Provide missing default attachment list for Files transactions

Summary

Ref T13682. This property may not exist, and should defualt to an empty array if not present.

Test Plan

Created a new object.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 23 2022, 4:24 PM

epriestley created this revision.

Harbormaster completed remote builds in B25736: Diff 52035.May 23 2022, 4:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 4:24 PM

Closed by commit rP8cd02e6727e3: Provide missing default attachment list for Files transactions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP8cd02e6727e3: Provide missing default attachment list for Files transactions.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

Diff 52036

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Provide missing default attachment list for Files transactionsClosedPublicActions