Provide missing default attachment list for Files transactions
ClosedPublic
Actions

Authored by epriestley on May 23 2022, 4:24 PM.

Tags

None

Referenced Files

	F19003856: D21834.diff
	Fri, Nov 21, 9:57 AM

	F18959484: D21834.id.diff
	Thu, Nov 13, 7:23 AM

	F18877034: D21834.diff
	Thu, Nov 6, 5:36 AM

	F18813358: D21834.diff
	Oct 20 2025, 3:38 PM

	F18786486: D21834.id52035.diff
	Oct 14 2025, 7:19 PM

	F18773345: D21834.id.diff
	Oct 9 2025, 9:08 AM

	F18770584: D21834.diff
	Oct 8 2025, 1:31 PM

	F18755518: D21834.id52035.diff
	Oct 5 2025, 5:58 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP8cd02e6727e3: Provide missing default attachment list for Files transactions

Summary

Ref T13682. This property may not exist, and should defualt to an empty array if not present.

Test Plan

Created a new object.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 23 2022, 4:24 PM

epriestley created this revision.

Harbormaster completed remote builds in B25736: Diff 52035.May 23 2022, 4:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 4:24 PM

Closed by commit rP8cd02e6727e3: Provide missing default attachment list for Files transactions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP8cd02e6727e3: Provide missing default attachment list for Files transactions.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

Diff 52036

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Provide missing default attachment list for Files transactionsClosedPublicActions