Page MenuHomePhabricator
Differential D21834

Provide missing default attachment list for Files transactions
ClosedPublic
Actions

Authored by epriestley on May 23 2022, 4:24 PM.
Tags
None
Referenced Files
F14002895: D21834.diff
Fri, Oct 25, 11:43 PM
F13982927: D21834.diff
Sun, Oct 20, 3:00 AM
F13982924: D21834.diff
Sun, Oct 20, 2:58 AM
F13982376: D21834.id52035.diff
Sat, Oct 19, 10:46 PM
F13982364: D21834.id.diff
Sat, Oct 19, 10:42 PM
F13982362: D21834.id52036.diff
Sat, Oct 19, 10:41 PM
F13973853: D21834.diff
Fri, Oct 18, 3:00 AM
F13973085: D21834.diff
Thu, Oct 17, 10:57 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP8cd02e6727e3: Provide missing default attachment list for Files transactions
Summary

Ref T13682. This property may not exist, and should defualt to an empty array if not present.

Test Plan

Created a new object.

Diff Detail

Repository
rP Phabricator
Branch
filex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25736
Build 35564: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 23 2022, 4:24 PM
epriestley created this revision.
Harbormaster completed remote builds in B25736: Diff 52035.May 23 2022, 4:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 4:24 PM
Closed by commit rP8cd02e6727e3: Provide missing default attachment list for Files transactions (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8cd02e6727e3: Provide missing default attachment list for Files transactions.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
2 lines

Diff 52035

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility