Provide missing default attachment list for Files transactions
ClosedPublic
Actions

Authored by epriestley on May 23 2022, 4:24 PM.

Tags

None

Referenced Files

	F22520850: D21834.diff
	Sun, Sep 20, 4:45 PM

	F22509847: D21834.id.diff
	Fri, Sep 18, 7:10 PM

	Unknown Object (File)
	Fri, Sep 11, 5:24 AM

	Unknown Object (File)
	Thu, Sep 3, 2:54 AM

	Unknown Object (File)
	Thu, Aug 27, 2:06 AM

	Unknown Object (File)
	Aug 18 2026, 4:33 PM

	Unknown Object (File)
	Aug 18 2026, 11:17 AM

	Unknown Object (File)
	Aug 17 2026, 8:23 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP8cd02e6727e3: Provide missing default attachment list for Files transactions

Summary

Ref T13682. This property may not exist, and should defualt to an empty array if not present.

Test Plan

Created a new object.

Diff Detail

Repository

rP Phabricator

Branch

filex1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25736
Build 35564: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 23 2022, 4:24 PM

epriestley created this revision.

Harbormaster completed remote builds in B25736: Diff 52035.May 23 2022, 4:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 4:24 PM

Closed by commit rP8cd02e6727e3: Provide missing default attachment list for Files transactions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP8cd02e6727e3: Provide missing default attachment list for Files transactions.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

Diff 52035

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Provide missing default attachment list for Files transactionsClosedPublicActions