Page MenuHomePhabricator

Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
ClosedPublic

Authored by epriestley on May 19 2022, 8:20 PM.
Tags
None
Referenced Files
F13171020: D21830.diff
Tue, May 7, 9:57 AM
Unknown Object (File)
Sun, May 5, 12:26 PM
Unknown Object (File)
Sat, May 4, 10:40 AM
Unknown Object (File)
Mon, Apr 22, 9:27 AM
Unknown Object (File)
Sat, Apr 20, 5:59 PM
Unknown Object (File)
Sat, Apr 20, 3:50 PM
Unknown Object (File)
Sat, Apr 20, 3:55 AM
Unknown Object (File)
Fri, Apr 19, 7:50 AM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on…
Summary

Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:

  • Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
  • Objects that use EditEngine to generate a comment area.

This is the vast majority of pathways, but not entirely exhaustive.

Test Plan

Created and commented on a task, explicitly attaching images. Saw images attach properly.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25732
Build 35560: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.