Page MenuHomePhabricator

Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
ClosedPublic

Authored by epriestley on May 19 2022, 8:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 12, 1:41 PM
Unknown Object (File)
Fri, Feb 7, 7:23 AM
Unknown Object (File)
Thu, Feb 6, 12:56 AM
Unknown Object (File)
Tue, Feb 4, 7:17 PM
Unknown Object (File)
Sun, Feb 2, 11:32 PM
Unknown Object (File)
Sun, Feb 2, 11:32 PM
Unknown Object (File)
Sun, Feb 2, 11:32 PM
Unknown Object (File)
Sun, Feb 2, 12:55 PM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on…
Summary

Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:

  • Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
  • Objects that use EditEngine to generate a comment area.

This is the vast majority of pathways, but not entirely exhaustive.

Test Plan

Created and commented on a task, explicitly attaching images. Saw images attach properly.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25732
Build 35560: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.