Page MenuHomePhabricator

Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
ClosedPublic

Authored by epriestley on May 19 2022, 8:20 PM.
Tags
None
Referenced Files
F15404010: D21830.id52020.diff
Tue, Mar 18, 5:51 AM
F15400754: D21830.id52030.diff
Mon, Mar 17, 1:51 PM
F15391559: D21830.id52030.diff
Sat, Mar 15, 10:33 AM
F15391558: D21830.id52020.diff
Sat, Mar 15, 10:33 AM
F15391557: D21830.id.diff
Sat, Mar 15, 10:33 AM
F15377463: D21830.diff
Thu, Mar 13, 9:01 AM
Unknown Object (File)
Wed, Feb 26, 10:23 AM
Unknown Object (File)
Wed, Feb 26, 9:26 AM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on…
Summary

Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:

  • Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
  • Objects that use EditEngine to generate a comment area.

This is the vast majority of pathways, but not entirely exhaustive.

Test Plan

Created and commented on a task, explicitly attaching images. Saw images attach properly.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25732
Build 35560: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.