Page MenuHomePhabricator

Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
ClosedPublic

Authored by epriestley on May 19 2022, 8:20 PM.
Tags
None
Referenced Files
F19796768: D21830.id52020.diff
Fri, Feb 27, 5:23 PM
F19536040: D21830.diff
Jan 21 2026, 9:38 AM
F19536028: D21830.diff
Jan 21 2026, 9:30 AM
F19536026: D21830.diff
Jan 21 2026, 9:30 AM
F19524082: D21830.diff
Jan 17 2026, 10:04 PM
F19517074: D21830.diff
Jan 15 2026, 7:22 AM
F19516014: D21830.id.diff
Jan 14 2026, 6:28 PM
F19513974: D21830.diff
Jan 13 2026, 8:21 PM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on…
Summary

Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:

  • Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
  • Objects that use EditEngine to generate a comment area.

This is the vast majority of pathways, but not entirely exhaustive.

Test Plan

Created and commented on a task, explicitly attaching images. Saw images attach properly.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25732
Build 35560: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.