Page MenuHomePhabricator

Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
ClosedPublic

Authored by epriestley on May 19 2022, 8:20 PM.
Tags
None
Referenced Files
F18346276: D21830.diff
Tue, Aug 26, 1:41 PM
F18345361: D21830.diff
Tue, Aug 26, 11:20 AM
F18196304: D21830.id.diff
Sun, Aug 17, 5:34 PM
F18182173: D21830.diff
Sat, Aug 16, 9:09 AM
F18119913: D21830.id52020.diff
Wed, Aug 13, 10:16 AM
F18106715: D21830.id.diff
Sun, Aug 10, 11:13 PM
F18081743: D21830.diff
Tue, Aug 5, 1:54 AM
F18078522: D21830.diff
Mon, Aug 4, 8:11 PM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on…
Summary

Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:

  • Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
  • Objects that use EditEngine to generate a comment area.

This is the vast majority of pathways, but not entirely exhaustive.

Test Plan

Created and commented on a task, explicitly attaching images. Saw images attach properly.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25732
Build 35560: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.