Page MenuHomePhabricator

Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
ClosedPublic

Authored by epriestley on May 19 2022, 8:20 PM.
Tags
None
Referenced Files
F12192699: D21830.diff
Sat, Sep 23, 2:51 AM
F12192604: D21830.diff
Sat, Sep 23, 1:58 AM
F12185956: D21830.diff
Sat, Sep 16, 3:55 PM
F12172203: D21830.diff
Fri, Sep 8, 1:05 PM
F12162437: D21830.diff
Wed, Sep 6, 8:15 PM
F12153855: D21830.diff
Mon, Sep 4, 3:34 AM
F12134565: D21830.id52030.diff
Aug 25 2023, 4:49 AM
F12134564: D21830.id52020.diff
Aug 25 2023, 4:49 AM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on…
Summary

Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:

  • Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
  • Objects that use EditEngine to generate a comment area.

This is the vast majority of pathways, but not entirely exhaustive.

Test Plan

Created and commented on a task, explicitly attaching images. Saw images attach properly.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25732
Build 35560: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.