Page MenuHomePhabricator

Generate file attachment transactions for explicit Remarkup attachments on common edit pathways
ClosedPublic

Authored by epriestley on May 19 2022, 8:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 10:23 AM
Unknown Object (File)
Wed, Feb 26, 9:26 AM
Unknown Object (File)
Wed, Feb 26, 7:28 AM
Unknown Object (File)
Fri, Feb 21, 12:31 PM
Unknown Object (File)
Fri, Feb 21, 5:10 AM
Unknown Object (File)
Tue, Feb 18, 4:58 AM
Unknown Object (File)
Mon, Feb 17, 9:24 AM
Unknown Object (File)
Mon, Feb 17, 8:12 AM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on…
Summary

Ref T13603. On common edit pathways, extract explicit file attachments from Remarkup. These pathways are affected:

  • Objects that use EditEngine and expose a remarkup area via "RemarkupEditField".
  • Objects that use EditEngine to generate a comment area.

This is the vast majority of pathways, but not entirely exhaustive.

Test Plan

Created and commented on a task, explicitly attaching images. Saw images attach properly.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25732
Build 35560: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.