Remove all "FileHasObject" edge reads and writes
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 10:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 27, 2:17 PM

	Unknown Object (File)
	Tue, Nov 26, 12:36 PM

	Unknown Object (File)
	Sat, Nov 23, 9:25 AM

	Unknown Object (File)
	Mon, Nov 18, 9:29 PM

	Unknown Object (File)
	Fri, Nov 15, 8:53 AM

	Unknown Object (File)
	Wed, Nov 13, 2:25 AM

	Unknown Object (File)
	Sun, Nov 10, 9:36 PM

	Unknown Object (File)
	Thu, Nov 7, 3:51 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task
Commits: rPb872640c160a: Remove all "FileHasObject" edge reads and writes

Summary

Ref T13603. Removes all reads and writes to the other half of the legacy edge.

Test Plan

Verified I could still see file content accessible only through object attachment.
This fixes a unit test broken by removal of only half the edge access in the previous change.

Diff Detail

Repository

rP Phabricator

Branch

file8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25719
Build 35547: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 12 2022, 10:25 PM

epriestley created this revision.

Harbormaster completed remote builds in B25719: Diff 52000.May 12 2022, 10:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM

Closed by commit rPb872640c160a: Remove all "FileHasObject" edge reads and writes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb872640c160a: Remove all "FileHasObject" edge reads and writes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

query/

PhabricatorFileQuery.php

34 lines

Diff 52000

View Options

src/applications/files/query/PhabricatorFileQuery.php

Remove all "FileHasObject" edge reads and writesClosedPublicActions