Ref T13603. Migrate all code which interacts with the "ObjectHasFile" edge to use the "Attachments" table instead.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes
- Edited a paste's view policy, confirmed associated file secret was scrambled.
- Verified I could still view paste content as a user who could not naturally view the underlying file.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- file7
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 25718 Build 35546: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 61 ms | PhabricatorFileTestCase::testFileIndirectScramble Assertion failed, expected 'true' (at PhabricatorFileTestCase.php:135): Changing attached object view policy should scramble secret.
ACTUAL VALUE
| |
| 30 ms | PhabricatorFileTestCase::testFileVisibility Assertion failed, expected values to be equal (at PhabricatorFileTestCase.php:200): Attached File Visibility
Expected vs Actual Output Diff
--- Old Value
| |
| 206 ms | PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed. | |
| 9 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 82 ms | PhabricatorFileTestCase::testFileDirectScramble 2 assertions passed. | |
| View Full Test Results (2 Failed · 15 Passed) |