Page MenuHomePhabricator

Remove all "ObjectHasFile" edge reads and writes
ClosedPublic

Authored by epriestley on May 12 2022, 10:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 7:17 PM
Unknown Object (File)
Tue, Mar 19, 5:25 PM
Unknown Object (File)
Sat, Mar 16, 11:55 AM
Unknown Object (File)
Sun, Mar 10, 10:39 PM
Unknown Object (File)
Feb 13 2024, 8:28 PM
Unknown Object (File)
Feb 12 2024, 1:11 AM
Unknown Object (File)
Feb 4 2024, 1:55 AM
Unknown Object (File)
Feb 4 2024, 1:55 AM
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes
Summary

Ref T13603. Migrate all code which interacts with the "ObjectHasFile" edge to use the "Attachments" table instead.

Test Plan
  • Edited a paste's view policy, confirmed associated file secret was scrambled.
  • Verified I could still view paste content as a user who could not naturally view the underlying file.

Diff Detail

Repository
rP Phabricator
Branch
file7
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25718
Build 35546: arc lint + arc unit

Unit TestsFailed

TimeTest
61 msPhabricatorFileTestCase::testFileIndirectScramble
Assertion failed, expected 'true' (at PhabricatorFileTestCase.php:135): Changing attached object view policy should scramble secret. ACTUAL VALUE
30 msPhabricatorFileTestCase::testFileVisibility
Assertion failed, expected values to be equal (at PhabricatorFileTestCase.php:200): Attached File Visibility Expected vs Actual Output Diff --- Old Value
206 msPhabricatorCelerityTestCase::testCelerityMaps
3 assertions passed.
9 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
82 msPhabricatorFileTestCase::testFileDirectScramble
2 assertions passed.
View Full Test Results (2 Failed · 15 Passed)

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 12 2022, 10:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.