Do not extract file PHIDs from remarkup blocks for attachment
ClosedPublic
Actions

Authored by epriestley on May 10 2022, 6:54 PM.

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task
Commits: rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment

Summary

Ref T13603. When processing transactions that include remarkup blocks, stop extracting file references from them for attachment.

Test Plan

Submitted a remarkup block with a file reference, no longer saw automatic file attachment.

Diff Detail

Repository

rP Phabricator

Branch

file1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25709
Build 35537: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 10 2022, 6:54 PM

epriestley created this revision.

Harbormaster completed remote builds in B25709: Diff 51989.May 10 2022, 6:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM

Closed by commit rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionCommentEditor.php

18 lines

PhabricatorApplicationTransactionEditor.php

8 lines

Diff 51989

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php