Page MenuHomePhabricator

Do not extract file PHIDs from remarkup blocks for attachment
ClosedPublic

Authored by epriestley on May 10 2022, 6:54 PM.
Tags
None
Referenced Files
F13217722: D21812.diff
Sat, May 18, 7:34 AM
F13198291: D21812.diff
Mon, May 13, 5:38 AM
F13188932: D21812.diff
Sat, May 11, 5:36 AM
F13183238: D21812.diff
Fri, May 10, 7:43 AM
Unknown Object (File)
Tue, May 7, 9:20 AM
Unknown Object (File)
Sat, May 4, 10:59 AM
Unknown Object (File)
Fri, May 3, 9:07 AM
Unknown Object (File)
Thu, May 2, 5:19 AM
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment
Summary

Ref T13603. When processing transactions that include remarkup blocks, stop extracting file references from them for attachment.

Test Plan

Submitted a remarkup block with a file reference, no longer saw automatic file attachment.

Diff Detail

Repository
rP Phabricator
Branch
file1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25709
Build 35537: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
This revision was automatically updated to reflect the committed changes.