Ref T13678. When remarkup content embeds other remarkup content, detect and degrade if the references have nesting depth greater than 1. This is a coarse cycle detector, since rendering shallow (but technically non-cycling) trees doesn't seem valuable.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13678: Remarkup objects may form rendering cycles when embedded
- Commits
- rP01253d533bbc: Prevent embedded remarkup content from cycling when it contains embedded self…
Created various objects with self-references, saw everything degrade properly (after one level of embedding) when embedded in itself and in other contexts. See attached screenshot.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- votex1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 25707 Build 35535: arc lint + arc unit