Page MenuHomePhabricator

Prevent embedded remarkup content from cycling when it contains embedded self-references
ClosedPublic

Authored by epriestley on May 9 2022, 6:20 PM.
Tags
None
Referenced Files
F13505783: D21810.diff
Tue, Jul 23, 5:32 PM
F13500503: D21810.diff
Tue, Jul 23, 4:30 AM
Unknown Object (File)
Mon, Jul 22, 2:44 PM
Unknown Object (File)
Mon, Jul 15, 1:30 PM
Unknown Object (File)
Sun, Jul 14, 8:56 AM
Unknown Object (File)
Tue, Jul 9, 9:37 PM
Unknown Object (File)
Fri, Jul 5, 11:15 AM
Unknown Object (File)
Thu, Jul 4, 11:19 PM
Subscribers
None

Details

Summary

Ref T13678. When remarkup content embeds other remarkup content, detect and degrade if the references have nesting depth greater than 1. This is a coarse cycle detector, since rendering shallow (but technically non-cycling) trees doesn't seem valuable.

Test Plan

Created various objects with self-references, saw everything degrade properly (after one level of embedding) when embedded in itself and in other contexts. See attached screenshot.

Diff Detail

Repository
rP Phabricator
Branch
votex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25707
Build 35535: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 9 2022, 6:21 PM
This revision was automatically updated to reflect the committed changes.