Formalize some more Drydock conditions and bookkeeping
ClosedPublic
Actions

Authored by epriestley on May 9 2022, 5:09 PM.

Details

Reviewers: None
Maniphest Tasks: T13677: Drydock may grow resource pools too cautiously
Commits: rP13a37282bcb3: Formalize some more Drydock conditions and bookkeeping

Summary

Ref T13677. Track which resources a given lease has begun allocating or reclaiming in a more formal way, and add logging for waiting actions.

The "allocating" mechanism is new. This will replace an existing similar "reclaiming" mechanism in a future change.

Test Plan

See followup changes.

Repository

rP Phabricator

Branch

drydock-2

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25701
Build 35529: arc lint + arc unit

	Time	Test
	470 ms	PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.DrydockLeaseWaitingForActivationLogType, class.DrydockLeaseWaitingForReclamationLogType, xmap.DrydockLeaseWaitingForActivationLogType, xmap.DrydockLeaseWaitingForReclamationLogType.
	5 ms	DrydockBlueprintImplementationTestCase::testGetAllBlueprintImplementations 1 assertion passed.
	210 ms	PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed.
	10 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed.
		View Full Test Results (1 Failed · 7 Passed)