Page MenuHomePhabricator

Don't reclaim resources that have a destroyed lease less than 3 minutes old
ClosedPublic

Authored by epriestley on May 3 2022, 10:54 PM.
Tags
None
Referenced Files
F19513311: D21803.id51962.diff
Tue, Jan 13, 10:52 AM
F19513287: D21803.id51962.diff
Tue, Jan 13, 10:34 AM
F19508171: D21803.id51962.diff
Sat, Jan 10, 1:51 AM
F19236476: D21803.id51970.diff
Sun, Dec 21, 7:10 PM
F19072853: D21803.id.diff
Nov 30 2025, 11:42 PM
F19072850: D21803.id.diff
Nov 30 2025, 11:41 PM
F19072819: D21803.id.diff
Nov 30 2025, 11:36 PM
F19072721: D21803.id.diff
Nov 30 2025, 11:29 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. The 3-minute grace period when a resource can not be reclaimed after its leases are released currently doesn't work reliably because the Resource object usually isn't actually updated when a lease is released.

Add an additional check for recently-destroyed leases, and extend the grace period if we find any.

Test Plan
  • See T13676. Ran reproduction sequence there, observed immediate resource reclamation.
  • Applied patch.
  • Ran sequence again, observed repository B wait 3 minutes to reclaim a repository A resource.

Diff Detail

Repository
rP Phabricator
Branch
drydock7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25698
Build 35526: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 3 2022, 10:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM
This revision was automatically updated to reflect the committed changes.