Page MenuHomePhabricator

Don't reclaim resources that have a destroyed lease less than 3 minutes old
ClosedPublic

Authored by epriestley on May 3 2022, 10:54 PM.
Tags
None
Referenced Files
F18288673: D21803.diff
Sat, Aug 23, 8:31 AM
F18263007: D21803.diff
Fri, Aug 22, 8:38 AM
F18234723: D21803.id.diff
Wed, Aug 20, 6:30 PM
F18214105: D21803.id51962.diff
Tue, Aug 19, 5:10 AM
F18156258: D21803.diff
Thu, Aug 14, 9:43 PM
F18106686: D21803.id.diff
Sun, Aug 10, 11:12 PM
F18081609: D21803.diff
Tue, Aug 5, 1:05 AM
F17949530: D21803.diff
Thu, Jul 31, 11:39 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. The 3-minute grace period when a resource can not be reclaimed after its leases are released currently doesn't work reliably because the Resource object usually isn't actually updated when a lease is released.

Add an additional check for recently-destroyed leases, and extend the grace period if we find any.

Test Plan
  • See T13676. Ran reproduction sequence there, observed immediate resource reclamation.
  • Applied patch.
  • Ran sequence again, observed repository B wait 3 minutes to reclaim a repository A resource.

Diff Detail

Repository
rP Phabricator
Branch
drydock7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25698
Build 35526: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 3 2022, 10:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM
This revision was automatically updated to reflect the committed changes.