Page MenuHomePhabricator
Differential D21755

Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT
ClosedPublic
Actions

Authored by epriestley on Apr 1 2022, 7:49 PM.
Tags
None
Referenced Files
F15566929: D21755.id51854.diff
Fri, May 2, 2:14 AM
F15529857: D21755.id51862.diff
Tue, Apr 22, 11:01 PM
F15521184: D21755.id.diff
Sun, Apr 20, 11:54 AM
F15518965: D21755.diff
Sat, Apr 19, 6:33 PM
F15464083: D21755.id51854.diff
Apr 2 2025, 6:22 AM
F15455806: D21755.diff
Mar 30 2025, 4:58 AM
F15421358: D21755.id51862.diff
Mar 21 2025, 10:56 PM
F15420775: D21755.id51854.diff
Mar 21 2025, 5:08 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13661: Give Phame configurable interact policies
Commits
rP4dae3e7e1fbf: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT
Summary

Ref T13661. Fix up some UI and language so it's more clear that this is about disabling blog comments.

Test Plan

Viewed UIs, saw some more usable strings.

Diff Detail

Repository
rP Phabricator
Branch
phameint8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25639
Build 35467: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Apr 1 2022, 7:49 PM
epriestley created this revision.
Harbormaster completed remote builds in B25639: Diff 51854.Apr 1 2022, 7:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2022, 7:53 PM
Closed by commit rP4dae3e7e1fbf: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP4dae3e7e1fbf: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
editor/
29 lines
storage/
8 lines

Diff 51854

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditEngineLock.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
Phabricator · Built by Phacility