Page MenuHomePhabricator
Differential D21754

Give Phame blog posts configurable interact policies, with a default policy of "Same as Blog"
ClosedPublic
Actions

Authored by epriestley on Apr 1 2022, 7:41 PM.
Tags
None
Referenced Files
F14115612: D21754.id51861.diff
Thu, Nov 28, 12:03 PM
F14111289: D21754.id51861.diff
Wed, Nov 27, 8:59 PM
Unknown Object (File)
Mon, Nov 25, 6:40 PM
Unknown Object (File)
Sun, Nov 24, 4:36 PM
Unknown Object (File)
Tue, Nov 19, 8:19 PM
Unknown Object (File)
Sat, Nov 16, 7:07 AM
Unknown Object (File)
Mon, Nov 11, 6:30 PM
Unknown Object (File)
Fri, Nov 8, 1:11 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13661: Give Phame configurable interact policies
Commits
rPaae23f020476: Give Phame blog posts configurable interact policies, with a default policy of…
Summary

Ref T13661. This allows posts to have comments disabled (or restricted) on a per-post basis, and makes them inherit the containing blog policy by default.

Test Plan

Locked a post by editing its policy explicitly; locked a post by editing the containing blog policy.

Diff Detail

Repository
rP Phabricator
Branch
phameint7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phame/policyrule/PhameInheritBlogPolicyRule.php:35XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 25638
Build 35466: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 1 2022, 7:41 PM
Owners added a subscriber: Restricted Owners Package.Apr 1 2022, 7:41 PM
epriestley requested review of this revision.Apr 1 2022, 7:41 PM
Harbormaster completed remote builds in B25638: Diff 51853.Apr 1 2022, 7:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2022, 7:53 PM
Closed by commit rPaae23f020476: Give Phame blog posts configurable interact policies, with a default policy of… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPaae23f020476: Give Phame blog posts configurable interact policies, with a default policy of….

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
6 lines
src/
applications/
phame/
editor/
2 lines
policyrule/
51 lines
storage/
13 lines

Diff 51853

View Options

resources/sql/autopatches/20220401.phameinteract.04.postinteract.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditor.php

Loading...
View Options

src/applications/phame/policyrule/PhameInheritBlogPolicyRule.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
Phabricator · Built by Phacility